[Partial] Fix for Issue #175: Implement RequireJS Error Handling#198
Open
long-m-r wants to merge 4 commits intoguybedford:masterfrom
Open
[Partial] Fix for Issue #175: Implement RequireJS Error Handling#198long-m-r wants to merge 4 commits intoguybedford:masterfrom
long-m-r wants to merge 4 commits intoguybedford:masterfrom
Conversation
Modified to support requirejs error handling [line 149-153] Also added support for dynamic css servers (fixes issue sites like Google Fonts API. where the files is at https://fonts.googapis.com/icon?family=Material+Icons) [line 160,165]
Update to match css.js changes
typo in regex
long-m-r
changed the title
long-m-r
changed the title
Collaborator
|
@long-m-r could u please squash commits into one? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the requirejs error callback for linkLoad. Works in Firefox v40 and Chrome v44.
Also modified the normalize/load function so it can be used with dynamically served css files. Solves an issue I had with Google's Fonts API where css files are located at an address like 'https://fonts.googleapis.com/icon?family=Material+Icons'. Now it doesn't append '.css' to files that either already have it (like before) or those which have a '?' in the address.