Extractor timings #865
Open
Extractor timings #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a wrapper around the base extractor class which is enabled if the root logger level is set to debug.
The wrapper enables recording and logging of the time used whenever the extractor is called. This does produce quite a bit logging but is useful when developing new extractors, in order to determine the time taken for each extractor call.
I do not believe that the debugging level is used very much in any other places inside of GraphNeT.
I am not using an init argument of the base extractor class to enable the timing, as that would require each of the sub-classes to also take this input argument and pass it on to the super class. This can be done if preferred but would require a lot of manual argument passing.