Conversation
9c527f3 to
a1a4945
Compare
|
I've updated the mr to not directly depend on the JavaLauncher class being available, and have moved the code to a new extended TwirlCompile class. The code should now be compatible with the full gradle range currently supported. |
|
So it looks like the integration tests are failing for this reason I had fixed a similar issue in #175 |
Signed-off-by: Clayton Walker <cwalker@sofi.org>
a1a4945 to
6317b33
Compare
|
I misread, that error was about optional and not nullable. I've removed the |
|
@JLLeitschuh any chance somebody at https://github.com/gradle can check a look? |
|
Unfortunately, I'm not with Gradle anymore |
|
@JLLeitschuh Sorry for the ping then. |
|
@big-guy hello! Any chance somebody at gradle can review these changes? |
|
So toolchains were added in gradle 6.7, so versions under that would now be unsupported. Example failure on Gradle 6.6 |
Allows for the overriding of the java version used to invoke the twirl template compiler.
Resulting build.gradle.kts syntax would look like
tasks.compilePlayTwirlTemplates { javaLauncher.set(javaToolchains.launcherFor { languageVersion.set(JavaLanguageVersion.of(8)) }) }Note that if you're using a new version of java already, you can set the version of java used by the scala compiler via
tasks.compileScala { javaLauncher.set(javaToolchains.launcherFor { languageVersion.set(JavaLanguageVersion.of(8)) }) }