Enhancement of cpp header-only-library sample#35
Open
Brenne wants to merge 1 commit intogradle:masterfrom
Open
Enhancement of cpp header-only-library sample#35Brenne wants to merge 1 commit intogradle:masterfrom
Brenne wants to merge 1 commit intogradle:masterfrom
Conversation
… from the outgoing config, disabling CppCompile and CreateStaticLibrary tasks. Signed-off-by: Kai Brennenstuhl <kai.brennenstuhl@gmail.com>
halotroop2288
approved these changes
Jan 1, 2023
Learning1313
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the static library from the outgoing config, disabling
CppCompileandCreateStaticLibrarytasksContext
Benefit of this solution is that no unnecessary static library is created and neither a dummy source. In addition the changes result in increased performance because unnecessary tasks are disabled.
gradle/gradle-native#1074
Contributor Checklist
./gradlew check(on my setup 3 tests in master fail, the same tests still fail)