fix: Setup CI against enterprise #2299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
wu-hui
force-pushed
the
push-qrzkmqzsuuot
branch
from
407b9ca to
a4fa9ba
Compare
wu-hui
changed the title
wu-hui
force-pushed
the
push-qrzkmqzsuuot
branch
from
c679897 to
7bee426
Compare
MarkDuckworth
approved these changes
Jan 30, 2026
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
Approved with suggestions.
| // This is somewhat surprising because the pipeline did ask specifically for genre not | ||
| // equal to null, | ||
| // however at the later distinct stage, UNSET is grouped as null and thus null appears | ||
| // in the result. |
Contributor
There was a problem hiding this comment.
+1. That is surprising.
| .select( | ||
| field("rating").equal(nullValue()).as("ratingIsNull"), | ||
| field("rating").equal(Double.NaN).as("ratingIsNaN"), | ||
| // arrayGet("title", 0) evaluates to UNSET |
Contributor
There was a problem hiding this comment.
Was this intentionally left in?
| "__id1_", | ||
| "_id1__", | ||
| "a"); | ||
| // TODO: SDK now implements stardard backend order. We need to change it to Enterprise order |
Contributor
There was a problem hiding this comment.
Just an idea. Why not make this sort order configurable? If it was a big enough deal to fix for standard edition last year, maybe we should still support the standard behavior with a config option.
| @@ -141,7 +141,8 @@ public void aggregateErrorMessageIfIndexIsMissing() throws Exception { | |||
| assumeFalse( | |||
| "Skip this test when running against the emulator because it does not require composite" | |||
| + " index creation.", | |||
Contributor
There was a problem hiding this comment.
This comment may need updating to match the new behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.