Skip to content

Conversation

@GautamSharda
Copy link
Contributor

@GautamSharda GautamSharda commented Jan 29, 2026

Insert diff check logic to migrated repos to determine if kokoro tests should be run.

Some evidence that the diff check logic is added in the right place and works is that adding it to nodejs-logging-winston/trampoline_v2.sh and diff checking ./github/ results in:

(1) The tests are skipped / trivially passed when a PR does not make a change in ./github/: "no op" case

(2) The tests run when a PR makes changes in ./github/: "run tests" case

In our case, we diff check the package being migrated i.e., handwritten/{package_name} instead. Also, in our case, we have to account for firestore, which uses trampoline.sh (v1 / legacy) instead of trampoline_v2.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/478965516 🦕

@GautamSharda GautamSharda requested a review from a team as a code owner January 29, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant