Sanitize dut_id for use in output file name#941
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
Sometimes the DUT id may contain characters that aren't appropriate for file names. Sanitize the dut_id, so that we can safely use any ID.
| def _get_valid_filename(s): | ||
| # Reference: https://stackoverflow.com/a/46801075 | ||
| s = str(s).strip().replace(' ', '_') | ||
| return re.sub(r'(?u)[^-\w.]', '_', s) |
There was a problem hiding this comment.
I've hit an issue before where the filename was too long for the filesystem, this could be guarded against too here.
Sometimes the DUT id may contain characters that aren't appropriate for
file names. Sanitize the dut_id, so that we can safely use any ID.
This change is