Open
Conversation
Contributor
|
I need this exact feature, so I second this pull request. |
Contributor
Author
|
You can take the file and add it to your project, that's what I did since it was never reviewed. |
tcm0116
reviewed
Mar 2, 2020
| "validators: " + str(phase_data["validators"]), | ||
| "measured_value: " + str(phase_data["measured_value"]), | ||
| "outcome: " + phase_data["outcome"], | ||
| "log: " + "\n".join(log_output), "\n"]) |
Contributor
There was a problem hiding this comment.
I was having an issue with this throwing an exception because there was no "validators" entry in the phase_data dictionary for a measurement generated by a monitor. The change below resolved that issue with me.
if "name" in phase_data:
output.extend(["name: " + phase_data["name"]])
if "validators" in phase_data:
output.extend(["validators: " + str(phase_data["validators"])])
if "measured_value" in phase_data:
output.extend(["measured_value: " + str(phase_data["measured_value"])])
if "outcome" in phase_data:
output.extend(["outcome: " + phase_data["outcome"]])
output.extend(["log: " + "\n".join(log_output), "\n"])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I added a callback to get JUNIT files as an output.
Why I did it
In CI context, Jenkins uses JUNIT files to record tests. I have based my work on the JSON factory example.
Test output call example
XML example
Test with Jenkins plugin Test results analyzer
Success
Failure
Note
I was not quite sure of what to put instead of
testin line 66This change is