Remove references to contacts in domain flows #2944
Merged
+95
−773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrodman
force-pushed
the
removeContactsFromDomainFlows
branch
from
8d3ab23 to
48cd92c
Compare
We've moved on from contacts entirely now so the only thing we really need to do is make sure that people don't include contacts in domain creates or updates. This also makes auth code checking easier too, because now the only auth code that you're allowed to provide is the domain auth code (not a contact auth code)
gbrodman
force-pushed
the
removeContactsFromDomainFlows
branch
from
48cd92c to
d88b0ad
Compare
weiminyu
approved these changes
Jan 29, 2026
Collaborator
weiminyu
left a comment
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu reviewed 32 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ptkach).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've moved on from contacts entirely now so the only thing we really need to do is make sure that people don't include contacts in domain creates or updates. This also makes auth code checking easier too, because now the only auth code that you're allowed to provide is the domain auth code (not a contact auth code)
This change is