Conversation
Collaborator
Author
|
Ping @gnab |
Owner
|
I like it :) 👍 |
Owner
|
That is, I'm pro merging, have no comments to the diffs which look fine, and I also think streamlining the release process sounds interesting. |
Collaborator
Author
|
Not 100% sure of the correctness of the Add release task, since it:
But that's the general idea! You would do the following: gulp release # normal 'patch bump (i.e., v2.1.2 to v2.1.3
gulp release --inc 'minor' # minor bump (i.e., v2.1.2 to v.2.2.0)
gulp release --inc 'major' # v2.1.2 to v3.0.0You can also test out (but it will leave your local repo is a weird state): gulp release --dry-run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've replaced the make.js system for build, minification, linting, and test with a gulp-based system. As far as I can tell, the output is pretty much the same; I did manage to add support for sourcemaps for the minified version of editableCell.
Looking for some feedback -
gulp bump --minor && gulp release