Open
Conversation
mattrothenberg
requested review from
Wattenberger and
jaked
and removed request for
Wattenberger
mattrothenberg
commented
Jan 4, 2023
Comment on lines
-14
to
-15
| // needed to close the dropdown, which is an uncontrolled detail element | ||
| const [iteration, setIteration] = useState(0); |
Contributor
Author
There was a problem hiding this comment.
This wasn't necessary on my end, though I might be missing some context or was testing it incorrectly. The dropdown closes fine upon item click; this behavior seems to be the default, looking at the Primer docs.
jaked
approved these changes
Jan 6, 2023
| import { | ||
| Block, | ||
| FolderBlockProps, | ||
| getNestedFileTree, |
Contributor
Author
There was a problem hiding this comment.
I believe so! Will fix :)
| "@fullstackio/cq": "^6.0.9", | ||
| "@fullstackio/remark-cq": "^6.1.2", | ||
| "@githubnext/blocks": "^2.2.0", | ||
| "@githubnext/blocks": "^2.4.0-1", |
There was a problem hiding this comment.
how do you make a candidate release like this?
Contributor
Author
There was a problem hiding this comment.
I use the tool np which allows you to create pre-releases and publish them to the next tag on NPM.
|
another thought here: should we consider changing the Blocks API so file trees are passed in a more useful way? rather than needing a library function in the block |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to githubnext/blocks-dev#21.
This PR fixes NEXT-634.
There's still an open experiential (and technical question) as to whether the file picker should disclose all of the files in the repository, or only those that are children of the current tree node.
In order to implement the former, I think we'll need an upstream change in
blocks-platformso that thetreeprop that gets passed down to folder blocks is always the highest-level tree, rather than the branch that's sliced according to the currentpath.A pre-requisite for merging this is publishing the
@githubnext/blockslibrary to the main channel again. Currently, I'm using anextbuild.