fix: 3d file block uses stage component, update r3f and drei#68
Open
drcmda wants to merge 1 commit intogithubnext:mainfrom
Open
fix: 3d file block uses stage component, update r3f and drei#68drcmda wants to merge 1 commit intogithubnext:mainfrom
drcmda wants to merge 1 commit intogithubnext:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i updated r3f and drei, also added @types/three which i think caused the typing issues.
also added the stage component which will automatically zoom to fit and center the models: https://twitter.com/0xca0a/status/1594409100271493120
as for the useGLTF hook creating a loop, perhaps the old versions caused that? can we try again with this one?