Merged
Conversation
Collaborator
Author
|
Dale if you approve this, I can then merge it into your PR and then I can merge your PR into master. To be clear - this is not the typical PR that merges into master. This one merges into averageProfile branch. |
Collaborator
Author
|
I built and tested these changes in QT5. |
|
🚀 New build available for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 3 commits:
The first one fixes the warnings with minimal changes (5 lines added or modified). Including making "storage" a member variable.
The second one renames "storage" to "m_temp_storage". No other changes.
The third commit gets rid of a comment that is no longer relevant.