Conversation
atsju
approved these changes
Jan 8, 2026
|
🚀 New build available for commit |
Collaborator
Author
|
So then Dale, should I change this one to save the string "nulled" instead? And note that the code that reads this line ignores the "1" so if someone puts a "0" instead of a "1" it won't change how the file is interpreted. Lines 993 to 994 in 55d8092 |
Collaborator
Author
|
Or can we leave it as is in this PR. |
Owner
|
I think it should be put to what it use to be. I'm not really sure if i changed it now. But if I did it was for debugging purposes and forgot to put it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorin noticed this "bug" introduced in v7.3.1. This only affects people who create wft files with other software. Software other than DFTFringe.