Skip to content

Fix timeout handling in CopilotSession #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
burkeholland wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −2
Open

Fix timeout handling in CopilotSession #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b83c76c
Fix timeout handling in CopilotSession to ensure process exists on close
burkeholland Jan 20, 2026
251d6d3
Clear timeout immedatel instead of in finally
burkeholland Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions nodejs/src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,12 @@ export class CopilotSession {
}
});

let timeoutId: NodeJS.Timeout | undefined;
try {
await this.send(options);

const timeoutPromise = new Promise<never>((_, reject) => {
setTimeout(
timeoutId = setTimeout(
() =>
reject(
new Error(
Expand All @@ -159,8 +160,13 @@ export class CopilotSession {
effectiveTimeout
);
});
await Promise.race([idlePromise, timeoutPromise]);

try {
await Promise.race([idlePromise, timeoutPromise]);
} finally {
// Clear timeout immediately after race completes to prevent memory leaks
if (timeoutId) clearTimeout(timeoutId);
}
return lastAssistantMessage;
} finally {
unsubscribe();
Expand Down
Loading