-
Notifications
You must be signed in to change notification settings - Fork 59
feat: add skillDirectories and disabledSkills to all SDKs #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Expose skill configuration options from CLI server to SDK clients: - skillDirectories: directories to load skills from - disabledSkills: list of skill names to disable Updated SDKs: - Node.js: SessionConfig, ResumeSessionConfig types and client - Go: SessionConfig, ResumeSessionConfig structs and client - .NET: SessionConfig, ResumeSessionConfig classes and client - Python: SessionConfig, ResumeSessionConfig TypedDicts and client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds skill configuration options (skillDirectories and disabledSkills) to all SDK clients, exposing these options from the CLI server to SDK consumers. The changes are consistent across all four SDK implementations (Node.js, Go, .NET, and Python).
Changes:
- Added
skillDirectoriesanddisabledSkillsconfiguration fields toSessionConfigandResumeSessionConfigtypes in all SDKs - Updated client implementations to serialize and send these fields to the server
- Updated Node.js package dependency to @github/copilot version 0.0.388-1
- Removed playground linting references from justfile
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| python/copilot/types.py | Added skill_directories and disabled_skills fields to SessionConfig and ResumeSessionConfig TypedDicts |
| python/copilot/client.py | Added serialization logic to send skillDirectories and disabledSkills in create_session and resume_session methods |
| nodejs/src/types.ts | Added skillDirectories and disabledSkills optional fields to SessionConfig interface and included them in ResumeSessionConfig Pick type |
| nodejs/src/client.ts | Added skillDirectories and disabledSkills to request payloads in createSession and resumeSession methods |
| nodejs/package.json | Updated @github/copilot dependency from ^0.0.387 to ^0.0.388-1 |
| nodejs/package-lock.json | Updated lockfile to reflect new @github/copilot version and platform-specific binaries |
| go/types.go | Added SkillDirectories and DisabledSkills fields to SessionConfig and ResumeSessionConfig structs with documentation |
| go/client.go | Added serialization logic to send skillDirectories and disabledSkills in CreateSession and ResumeSessionWithOptions methods |
| dotnet/src/Types.cs | Added SkillDirectories and DisabledSkills properties to SessionConfig and ResumeSessionConfig classes with XML documentation |
| dotnet/src/Client.cs | Updated CreateSessionRequest and ResumeSessionRequest records to include SkillDirectories and DisabledSkills parameters |
| justfile | Removed playground linting commands from lint-nodejs target |
Files not reviewed (1)
- nodejs/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Expose skill configuration options from CLI server to SDK clients:
Updated SDKs: