Skip to content

Conversation

@yoff
Copy link
Contributor

@yoff yoff commented Jan 9, 2026

It should be easy enough to ad tuple element (although these should take an index) and set element. List element was added in response to a user question. The change is trivial as it simply maps to the already supported subscript.

@yoff yoff requested a review from a team as a code owner January 9, 2026 12:10
Copilot AI review requested due to automatic review settings January 9, 2026 12:10
@github-actions github-actions bot added the Python label Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the ListElement token in Models as Data (MaD) for Python, enabling users to specify list element access in data flow models. The implementation maps ListElement to the existing subscript functionality, reusing infrastructure already in place for list element content.

Key changes:

  • Enabled ListElement token in MaD access paths by treating it the same as DictionaryElementAny
  • Updated test case to verify list element source detection works correctly
  • Added ListElement to the list of valid tokens for identifying access paths

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
python/ql/test/library-tests/frameworks/data/test.ext.yml Uncommented test case for ListElement to validate the new functionality
python/ql/test/library-tests/frameworks/data/test.expected Added expected test output showing that list element sources are now detected
python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModelsSpecific.qll Added ListElement support to token handling predicates, mapping it to subscript access

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# test steps through content
- ["testlib", "Member[source_dict].DictionaryElement[key].Member[func].ReturnValue", "test-source"]
- ["testlib", "Member[source_dict_any].DictionaryElementAny.Member[func].ReturnValue", "test-source"]
# TODO: Add support for list/tuples
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO comment should be updated to reflect that list support has now been added. Consider changing it to "TODO: Add support for tuples" since only tuple support remains unimplemented.

Suggested change
# TODO: Add support for list/tuples
# TODO: Add support for tuples

Copilot uses AI. Check for mistakes.
tausbn
tausbn previously approved these changes Jan 9, 2026
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks very reasonable, modulo a small issue of naming that I just want to make sure we've thought about. 🙂

@tausbn tausbn merged commit 5414bd2 into github:main Jan 20, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants