Some belated spring-cleaning of please.sh
#654
+0
−2,665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been removed from Git for Windows, and even before that, it was unsupported for several years. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We used to upgrade packages using a single command, but that did not integrate well with GitHub Actions. Therefore we now have the system where the `monitor-components.yml` workflow monitors for new versions, opening new tickets if there are, the `/open pr` commands can be used in those tickets to open Pull Requests in MINGW-packages, MSYS2-packages or build-extra, and the `/add release-note` command can then update the release notes. Therefore we do not need that old shell function anymore. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This function was used to prepare the release notes and the announcement mail in the Azure Pipelines in which Git for Windows was released. However, nowadays this task is performed elsewhere, specifically https://github.com/git-for-windows/git-for-windows-automation/blob/main/update-scripts/tag-git.sh For that reason, we do not need to carry this function anymore. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This logic was used in Azure Pipelines to finalize the release notes before releasing new Git for Windows versions. These days, that job is performed elsewhere, specifically in https://github.com/git-for-windows/git-for-windows-automation/blob/56d8604016d6/update-scripts/tag-git.sh#L55-L62 So let's retire that function (and some support functions, too). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
These packages are no longer built using `please.sh`, but using scripts contained in https://github.com/git-for-windows/git-for-windows-automation. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The Coverity stuff now lives in upstream Git's `coverity.yml` workflow. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
That logic now lives in https://github.com/git-for-windows/git-for-windows-automation/blob/main/update-scripts/tag-git.sh Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This was used in the release process that has migrated completely to git-for-windows-automation, and in the Coverity stuff (which has moved to upstream Git anyway). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The process to upstream `mingw-w64-git` to the MSYS2 project will have to be done very, very differently now. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
@rimrul @mjcheetham gentle ping? I know this is a large diff... |
rimrul
requested changes
Jan 11, 2026
Member
rimrul
left a comment
rimrul
left a comment
There was a problem hiding this comment.
We should probably keep sign_files(). Other than that, there are some cases where functions are delete before their callers, but that probably doesn't matter.
| require mingw-w64-i686-asciidoctor | ||
| } | ||
|
|
||
| pkg_build () { |
Member
| } | ||
|
|
||
| # require <metapackage> <telltale> | ||
| require () { |
Member
| done | ||
| } | ||
|
|
||
| process_keep_despite_upgrade () { # [--keep] <sdk-path> |
Member
| test t = "$independent_shell" | ||
| } | ||
|
|
||
| prepare_keep_despite_upgrade () { # <sdk-path> |
Member
| die "Could not update 32-bit SDK's release notes\n" | ||
| } | ||
|
|
||
| sign_files () { |
Member
There was a problem hiding this comment.
release_sdk() is a remaining caller of sign_files().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the years, a lot of the functionality in that monster of a Unix shell script has been moved and/or reimplemented elsewhere. It's time to clean up.