Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 26, 2026

Makes use of craft's new feature to detect npm packages in topological order. This makes our publishing process slightly more robust since previously, we didn't specify an explicit order. This is also a trial run for the sentry-javascript repo, so that we can test the craft option on a smaller monorepo like this one.

> volta run --node 20.18.2 npx @sentry/craft@latest targets
[info] Discovered 6 publishable yarn workspace packages
[
    "github",
    "npm[@sentry/babel-plugin-component-annotate]",
    "npm[@sentry/bundler-plugin-core]",
    "npm[@sentry/webpack-plugin]",
    "npm[@sentry/vite-plugin]",
    "npm[@sentry/rollup-plugin]",
    "npm[@sentry/esbuild-plugin]"
]

@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 changed the base branch from main to lms/chore-repo-auto-changelog January 26, 2026 10:03
@Lms24 Lms24 self-assigned this Jan 26, 2026
@Lms24 Lms24 requested review from andreiborza and chargome January 26, 2026 10:05
Base automatically changed from lms/chore-repo-auto-changelog to main January 26, 2026 10:13
@Lms24 Lms24 force-pushed the lms/chore-repo-npm-workspace-target branch from 4372dc1 to d855927 Compare January 26, 2026 10:13
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dumb question: do we then still need includeNames and the tarballs specified in requireNames?

@Lms24
Copy link
Member Author

Lms24 commented Jan 26, 2026

dumb question: do we then still need includeNames and the tarballs specified in requireNames?

Good question, I'm not sure actually! @BYK can we remove them safely? I think it doesn't hurt having them but if they're no longer necessary, happy to remove them.

@Lms24 Lms24 requested a review from BYK January 26, 2026 10:27
@BYK
Copy link
Member

BYK commented Jan 26, 2026

You'd probably need requireNames to be set as it is the artifact provider config and npm target cannot (and should not) influence that setting.

includeNames should be set automatically here: https://github.com/getsentry/craft/blob/abd8cd1fe1f3bdca1fc8e9d9dafa2bad5d5fd665/src/targets/npm.ts#L209-L219

@Lms24 Lms24 merged commit 335f317 into main Jan 26, 2026
24 checks passed
@Lms24 Lms24 deleted the lms/chore-repo-npm-workspace-target branch January 26, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants