Add go to metrics product page #16193
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| - <LinkWithPlatformIcon | ||
| platform="go.fasthttp" | ||
| label="FastHTTP" | ||
| url="/platforms/go/guides/fasthttp/metrics/" | ||
| /> |
There was a problem hiding this comment.
Bug: Inconsistent indentation for the new Go framework list items will cause them to render as nested sub-items instead of peer items, misrepresenting their relationship.
Severity: MEDIUM
Suggested Fix
Remove the leading spaces from all new list items under the Go section (lines 31-35 and beyond). Ensure all framework entries under a language start with - <LinkWithPlatformIcon at the same indentation level to render them as a flat list of peers.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/product/explore/metrics/getting-started/index.mdx#L31-L35
Potential issue: The new list items for Go frameworks in `index.mdx` use a mix of zero,
one, and two-space indents. According to Markdown specifications, indenting a list item
with two or more spaces makes it a nested sub-item of the preceding item. This will
cause the FastHTTP, Fiber, Gin, and other frameworks to incorrectly appear as sub-guides
of the `Echo` framework in the rendered documentation. This contradicts the established
structure where related SDKs are presented as peer items, which will confuse users.
There was a problem hiding this comment.
This is ok, they can be listed in peers in this context.
| ### Go | ||
|
|
||
| - <LinkWithPlatformIcon | ||
| platform="go" | ||
| label="Go" | ||
| url="/platforms/go/metrics/" | ||
| /> | ||
| - <LinkWithPlatformIcon | ||
| platform="go.echo" | ||
| label="Echo" |
There was a problem hiding this comment.
Bug: The PR adds 10 links to Go metrics documentation pages that do not exist, which will result in 404 errors for users.
Severity: MEDIUM
Suggested Fix
Update the href attributes for the newly added Go LinkWithPlatformIcon components to point to the correct, existing common metrics documentation page. The valid path is likely /platforms/go/common/metrics/.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/product/explore/metrics/getting-started/index.mdx#L19-L28
Potential issue: The pull request introduces 10 new links for Go-specific metrics
guides, such as `/platforms/go/guides/gin/metrics/`. However, these corresponding
documentation pages do not exist in the codebase. The analysis confirms the absence of
these files and also verifies that no server-side redirects are in place to handle these
broken paths. Users clicking these links will encounter a 404 error. The correct
documentation is located at a common path, not at the guide-specific paths being linked.
There was a problem hiding this comment.
These are not 404s.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES