feat(span-first): Clarify ignoreSpans must be evaluated before span starts
#16150
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add implementation requirement specifying that ignoreSpans patterns must be evaluated before the span is started to ensure ignored spans are never created and avoid unnecessary overhead. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
buenaflor
changed the title
ignoreSpans must be evaluated before span starts
Clarified implementation requirements for span filtering, including evaluation order and matching rules for attributes.
Clarified implementation requirements for ignoring spans in telemetry.
coolguyzone
reviewed
Jan 27, 2026
coolguyzone
reviewed
Jan 27, 2026
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+82
to
84
| 1. The `ignoreSpans` patterns MUST be evaluated **before** the span is started. | ||
| 2. The `ignoreSpans` patterns MUST be applied to all spans, including the root or segment span. | ||
| - If a pattern matches the root span, the span and all its children MUST be ignored. |
There was a problem hiding this comment.
Bug: The documentation requires ignoreSpans to be evaluated before a span starts, but provides examples that filter on attributes like http.status_code, which are only available after.
Severity: MEDIUM
Suggested Fix
Re-evaluate the ignoreSpans requirement. Either remove the strict "MUST be evaluated before the span is started" clause, or update the examples to only use attributes available at span creation. Alternatively, explicitly state that filtering on post-start attributes is not supported, or specify a multi-stage filtering process if it is intended to be supported.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: develop-docs/sdk/telemetry/spans/filtering.mdx#L82-L84
Potential issue: The documentation introduces a logical contradiction by requiring
`ignoreSpans` patterns to be evaluated before a span starts, while simultaneously
providing examples that filter on attributes only available after a span completes, such
as `http.status_code`. This creates an impossible implementation scenario for SDK
developers, forcing them to either ignore the new strict requirement or fail to support
the documented examples. This ambiguity will likely lead to inconsistent filtering
behavior across different SDKs, undermining the goal of a unified specification.
Did we get this right? 👍 / 👎 to inform future reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ignoreSpanspatterns must be evaluated before the span is started🤖 Generated with Claude Code