Conversation
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
left a comment
There was a problem hiding this comment.
lgtm; only concern is if we want to be continuously adding new packages / groups to our dependencies? Do we want to have dependency groups for these well-known use cases like litellm for aws? and if so, we should have the aws optional dependency depend on the mellea[litellm] optional dependency.
|
Okay, I decided to move Background/explanation: I initially added
But (1) is not a valid reason for breaking out a separate And (2) is valid, but mellea is already heavy and we already have a slimming-down of mellea-core in our backlog. So for now there's no harm in adding one more dependency to an already heavy list. So, given that more optionals is worse, ceteris paribus, and that That change is in and I also added an openai example. @jakelorocco would you mind re-reviewing and double-checking the examples given that we're not running cicd on them? Also, @jakelorocco , do we still have tests that go through and run all of the examples? If so we should mark these as ignores. But I don't see that in the |
This reverts commit 649743a.
Misc PR
Type of PR
Description
This PR adds a Bedrock example. Tests are not added because testing requires an AWS Bedrock key.
Testing