Skip to content

docs: Bedrock example.#410

Open
nrfulton wants to merge 19 commits intogenerative-computing:mainfrom
nrfulton:bedrock
Open

docs: Bedrock example.#410
nrfulton wants to merge 19 commits intogenerative-computing:mainfrom
nrfulton:bedrock

Conversation

@nrfulton
Copy link
Member

@nrfulton nrfulton commented Feb 4, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue:

This PR adds a Bedrock example. Tests are not added because testing requires an AWS Bedrock key.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Feb 4, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@nrfulton nrfulton changed the title Adds Bedrock example. docs: Bedrock example. Feb 4, 2026
@nrfulton nrfulton marked this pull request as ready for review February 4, 2026 15:00
@nrfulton nrfulton requested a review from jakelorocco February 4, 2026 15:00
Copy link
Contributor

@jakelorocco jakelorocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; only concern is if we want to be continuously adding new packages / groups to our dependencies? Do we want to have dependency groups for these well-known use cases like litellm for aws? and if so, we should have the aws optional dependency depend on the mellea[litellm] optional dependency.

@nrfulton
Copy link
Member Author

nrfulton commented Feb 5, 2026

Okay, I decided to move aws into the litellm optional.

Background/explanation:

I initially added boto3 to the litellm optional (hence the stray , in the litellm portion of that diff). But I then thought better of it and created [aws] for two reasons:

  1. you can use bedrock with other client libraries. For example see the gpt-oss 120b example in the boto3 docs.
  2. obviously, litellm works with other inference providers, so boto3 is usually not needed, so we're forcing people to download some code they don't need.

But (1) is not a valid reason for breaking out a separate aws group because the OpenAI backend does not require boto3.

And (2) is valid, but mellea is already heavy and we already have a slimming-down of mellea-core in our backlog. So for now there's no harm in adding one more dependency to an already heavy list.

So, given that more optionals is worse, ceteris paribus, and that boto3 is not always needed for bedrock, I think the best thing to do here is to move boto3 to litellm as @jakelorocco suggests.

That change is in and I also added an openai example. @jakelorocco would you mind re-reviewing and double-checking the examples given that we're not running cicd on them?

Also, @jakelorocco , do we still have tests that go through and run all of the examples? If so we should mark these as ignores. But I don't see that in the tests/ dir anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants