fix: formatting model_ids for better readability#386
fix: formatting model_ids for better readability#386psschwei merged 2 commits intogenerative-computing:mainfrom
Conversation
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
likely conflict with #357, but easy resolution Did you verify how ruff will format? sometimes there are heuristics relating to how many parameters for single vs multi-line - can be updated in rules but I'd go with defaults. |
from my searching, seems to do this requires turning off the formatter for this file as stated above. As the file is mostly constants I think that's ok (but it's a tradeoff and others may have different opinions on if its worth it) |
|
Per @ajbozarth suggestion, instead of disabling the linter, adding comments to each line to hack linebreaks |
HendrikStrobelt
left a comment
There was a problem hiding this comment.
Nice idea and solution (without changing the linter).
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
0103389 to
997db22
Compare
Misc PR
Type of PR
Description
Allows all model IDs to have a consistent format optimized for readability (name for each backend on its own line):
Example:
Personally, I think this helps make it easier to see which IDs work with which backend(s), but will leave it up to the group to decide if its worth merging.
Testing