feat: allow BaseSamplingStrategy to specify a concurrency budget#240
Open
jakelorocco wants to merge 1 commit intomainfrom
Open
feat: allow BaseSamplingStrategy to specify a concurrency budget#240jakelorocco wants to merge 1 commit intomainfrom
jakelorocco wants to merge 1 commit intomainfrom
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigated added a concurrency budget to base sampling strategy (and its subclasses). By increasing concurrency, you increase the number of sampling iterations that happen concurrently (ie generate/validate pairs).
I looked into some other solutions of how to add this concurrency parameter (like creating a total_budget, etc...), but none of them kept the meaning of loop_budget as what it is now while being intelligible. I think specifying a separate concurrency budget makes the most sense since it keeps existing sampling strategies the same while allowing for an easy way to improve the rate of sampling.
For example:
Changes:
Tests: