Allow intellij to load the feature-examples project without GEMFIRE_HOME#43
Open
upthewaterspout wants to merge 3 commits intogemfire:mainfrom
Open
Allow intellij to load the feature-examples project without GEMFIRE_HOME#43upthewaterspout wants to merge 3 commits intogemfire:mainfrom
upthewaterspout wants to merge 3 commits intogemfire:mainfrom
Conversation
We added validation to the *configuration* of the checkEnv task. That meant that even parsing the gradle build failed immediately. The validation should happen when the task runs.
onichols-pivotal
approved these changes
Jun 14, 2024
These properties should be checked before configuring the project to give a nicer error message. GEMFIRE_HOME can be checked later in the doLast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added validation to the configuration of the checkEnv task. That meant that even parsing the gradle build failed immediately. The validation should happen when the task runs.