fix: Added per rank log file for ODM#168
Merged
kmehant merged 4 commits intofoundation-model-stack:mainfrom Jan 30, 2026
Merged
fix: Added per rank log file for ODM#168kmehant merged 4 commits intofoundation-model-stack:mainfrom
kmehant merged 4 commits intofoundation-model-stack:mainfrom
Conversation
Signed-off-by: romit <romit@ibm.com>
Signed-off-by: romit <romit@ibm.com>
Signed-off-by: romit <romit@ibm.com>
romitjain
changed the title
kmehant
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where different processes were writing to the same log file, causing intermittent
OSError.Now, every rank will write to a separate file instead of writing a single file. The number of logs written will be same as before, but separated by files.
Since ODM sampling with accelerate dataloader can get quite involved (with dispatch batches, split batches), it is better to keep per rank log files for debugging (instead of only allowing rank 0 to log)