Add OAuth PKCE Selenium test automation with test seam pattern#1629
Open
amers185 wants to merge 6 commits intoforcedotcom:masterfrom
Open
Add OAuth PKCE Selenium test automation with test seam pattern#1629amers185 wants to merge 6 commits intoforcedotcom:masterfrom
amers185 wants to merge 6 commits intoforcedotcom:masterfrom
Conversation
…ly device flow is enabled:
* This represents the scenario before 7 AM on 9/2 when Connected Apps only support device flow.
* DL version 64.0.1 only supports PKCE, so this should fail gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds automated testing for OAuth PKCE flow using Selenium WebDriver, eliminating the need for manual browser interaction during testing.
🔧 Implementation
Test Seam Pattern
📁 Files Added/Modified
New Files:
Modified Files:
🔍 Technical Details
Uses the test seam pattern to inject Selenium control into the OAuth flow without modifying core business logic. When URLUtil.openURL() is called during tests, the test hook redirects to Selenium WebDriver instead of the system browser.
This approach solves the "Two Browser Problem" where DataLoader opens the system browser but tests need to control a Selenium browser.
🏗️ Architecture
The implementation keeps production logic embedded in URLUtil while providing a clean test hook: