Open
Conversation
Practicing technical writing.
davissp14
reviewed
Aug 10, 2021
|
|
||
| `REPL_PASSWORD` is used to replicate between instances. | ||
|
|
||
| 'OPERATOR_PASSWORD' is used to create a "root" user when a cluster is initialized. |
Contributor
There was a problem hiding this comment.
Same as above, replace single quotes with backticks.
|
|
||
| ### Set secrets | ||
| This app requires `SU_PASSWORD` and `REPL_PASSWORD` environment variables. | ||
| This app requires `SU_PASSWORD` and `REPL_PASSWORD` environment variables and gives users the option to create a "root" account on new database clusters using 'OPERATOR_PASSWORD'. |
Contributor
There was a problem hiding this comment.
Let's replace the single quotations with backtick's for consistency. E.G. OPERATOR_PASSWORD instead of 'OPERATOR_PASSWORD'.
and gives users the option to create a "root" account on new database clusters
We could maybe make this a bit more direct. Maybe something like:
This app requires SU_PASSWORD and REPL_PASSWORD environment variables. Optionally, you may specify the OPERATOR_PASSWORD to create an initial "postgres" user on provision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Practicing technical writing.