Fixes to missing or stale dimensions in DevTools analytics #9624
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
requested review from
bkonyi and
srawlins
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9622
Fixes a potential race condition in
setupDimensionswhere, if it was called twice in a row the first call would set_computingDimensions = trueand the second call would immediately return, regardless of whether the first call had completed leading to missing data in our analytics.Also fixes #9623:
Removes guards to
setupUserApplicationDimensions(and_computeUserApplicationCustomGTagData, which it calls). This function is called every time the VM service connection changes, therefore we were not re-computing the dimensions for a newly connected app leading to incorrect data in our analytics.Note: catches errors in both methods so that if setting up our analytics fails in any way we won't crash the app.