Fix flet_rive extension to work with Rive 0.14.2 update#6128
Fix flet_rive extension to work with Rive 0.14.2 update#6128FeodorFitsner merged 1 commit intomainfrom
flet_rive extension to work with Rive 0.14.2 update#6128Conversation
Update pubspec.lock with newer transitive package versions and checksums (cross_file, hooks, record_* packages, rive, rive_native, etc.). Adapt Rive usage in rive.dart to the newer API: replace machine.onInputChanged handlers with addAdvanceRequestListener/_onAdvanceRequested, remove the _inputHandlers list and its disposal, remove artboard.updatePass() from the advance check, and ensure advance request listeners are removed on dispose. These changes align the code with updated Rive package behavior and dependency updates.
|
@copilot update pull request description. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 531c59e7e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR updates the flet_rive extension to be compatible with Rive 0.14.2 by migrating from the deprecated input change handler API to the new advance request listener API.
Changes:
- Migrated from
onInputChangedcallback handlers toaddAdvanceRequestListenerAPI for state machine event handling - Removed obsolete
artboard.updatePass()call from the advance logic - Updated transitive dependencies in
pubspec.lockincluding rive (0.14.1 → 0.14.2), rive_native, cross_file, hooks, and record_* packages
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/python/packages/flet-rive/src/flutter/flet_rive/lib/src/rive.dart | Migrated state machine event handling from input change handlers to advance request listeners, removed the _inputHandlers list, updated cleanup logic to remove listeners before disposal, and simplified artboard advance logic |
| client/pubspec.lock | Updated dependency versions and checksums for rive, rive_native, cross_file, hooks, and various record_* packages to reflect Rive 0.14.2 compatibility updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update pubspec.lock with newer transitive package versions and checksums (cross_file, hooks, record_* packages, rive, rive_native, etc.). Adapt Rive usage in rive.dart to the newer API: replace machine.onInputChanged handlers with addAdvanceRequestListener/_onAdvanceRequested, remove the _inputHandlers list and its disposal, remove artboard.updatePass() from the advance check, and ensure advance request listeners are removed on dispose. These changes align the code with updated Rive package behavior and dependency updates.
Summary by Sourcery
Update Rive integration to be compatible with the Rive 0.14.2 API and clean up obsolete listeners and handlers.
Enhancements:
Build: