Skip to content

Conversation

@yeguclu
Copy link

@yeguclu yeguclu commented Jan 16, 2026

📝 Summary

Unify optimistic v1 and v3 submissions to use BidAdjustmentDataV3 format, removing BidAdjustmentDataV1 and intermediate conversion methods.

💡 Motivation and Context

For payout transactions, gas_used may differ from gas_limit. BidAdjustmentDataV3(https://docs.ultrasound.money/builders/optimistic-v3) format relaxes the gas_limit == gas_used assumption by explicitly providing placeholder_gas_used, allowing the relay to use the actual gas consumed.

In addition to optimistic v3 submissions, there already is a support for using the BidAdjustmentDataV3 with optimistic v1 submissions. Currently in rbuilder codebase, v1 submissions used BidAdjustmentDataV1 while v3 submissions used BidAdjustmentDataV2. Changing those submission types to use v3 data allows relays to use the actual gas consumed, preventing adjustment failures when gas_used differs from gas_limit, and will increase builder adjustment revenues.

Therefore we can simplify the codebase by:

  • Removing BidAdjustmentDataV1 entirely
  • Removing the intermediate BidAdjustmentData struct and conversion methods
  • Using BidAdjustmentDataV3 directly for both optimistic submission methods

✅ I have completed the following steps:

  • [✅ ] Run make lint
  • [✅ ] Run make test
  • Added tests (if applicable)

@yeguclu yeguclu changed the title refactor: update optimistic v3 adjustments to use adjustment data v3 feat: update optimistic v3 adjustments to use adjustment data v3 Jan 22, 2026
@yeguclu yeguclu changed the title feat: update optimistic v3 adjustments to use adjustment data v3 feat: update optimistic submissions to use adjustment data v3 Jan 22, 2026
@yeguclu yeguclu changed the title feat: update optimistic submissions to use adjustment data v3 feat: update both optimistic submission methods to use adjustment data v3 Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant