-
Notifications
You must be signed in to change notification settings - Fork 51
Chore: update minimum cmake version to 3.22 #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a maintenance update to the project's build configuration by increasing the minimum required CMake version to 3.22 across both the main project and its external dependencies. This change is crucial for maintaining compatibility and alignment with the underlying C++ SDK, potentially enabling the use of newer CMake features and ensuring a consistent build environment. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the minimum required CMake version to 3.22. This is a good maintenance task to keep the project's dependencies in sync. The changes are correct, but I've added a couple of suggestions to add/update comments to improve the long-term maintainability of these CMake files by clarifying the reasons for the version requirement.
|
|
||
| # Higher CMake version needed for improvments in UseSwig.cmake and string join | ||
| cmake_minimum_required (VERSION 3.13.4) | ||
| cmake_minimum_required(VERSION 3.22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability, consider updating the comment on line 17. The current comment is still relevant, but adding the context from the PR description (syncing with the C++ SDK) would be beneficial for future developers. For example:
# Minimum CMake version to keep in sync with the C++ SDK.
# This also provides improvements in UseSwig.cmake and string(JOIN).
c_minimum_required(VERSION 3.22)| # project, which is done via external_rules.cmake, one directory above. | ||
|
|
||
| cmake_minimum_required(VERSION 3.1) | ||
| cmake_minimum_required(VERSION 3.22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability, it would be helpful to add a comment explaining why this specific minimum version of CMake is required. This provides context for future developers. Since this file is for a sub-project, syncing with the main project's CMake version is a good reason.
Consider adding a comment like:
# Keep minimum CMake version in sync with the main project.
c_minimum_required(VERSION 3.22)
Description
Chore: update minimum cmake version to 3.22
This will also keep things in sync with the underlying C++ sdk.
Testing
Run a full integration test and build.
Type of Change
Place an
xthe applicable box: