Skip to content

Conversation

@AustinBenoit
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Chore: update minimum cmake version to 3.22

This will also keep things in sync with the underlying C++ sdk.


Testing

Describe how you've tested these changes.

Run a full integration test and build.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a maintenance update to the project's build configuration by increasing the minimum required CMake version to 3.22 across both the main project and its external dependencies. This change is crucial for maintaining compatibility and alignment with the underlying C++ SDK, potentially enabling the use of newer CMake features and ensuring a consistent build environment.

Highlights

  • Minimum CMake Version Update: The minimum required CMake version has been updated from 3.13.4 to 3.22 in the main CMakeLists.txt file.
  • External Dependencies CMake Version: The minimum required CMake version for external dependencies has been updated from 3.1 to 3.22 in cmake/external/CMakeLists.txt.
  • C++ SDK Synchronization: These updates ensure synchronization with the underlying C++ SDK, aligning the build environment with its requirements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum required CMake version to 3.22. This is a good maintenance task to keep the project's dependencies in sync. The changes are correct, but I've added a couple of suggestions to add/update comments to improve the long-term maintainability of these CMake files by clarifying the reasons for the version requirement.


# Higher CMake version needed for improvments in UseSwig.cmake and string join
cmake_minimum_required (VERSION 3.13.4)
cmake_minimum_required(VERSION 3.22)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, consider updating the comment on line 17. The current comment is still relevant, but adding the context from the PR description (syncing with the C++ SDK) would be beneficial for future developers. For example:

# Minimum CMake version to keep in sync with the C++ SDK.
# This also provides improvements in UseSwig.cmake and string(JOIN).
c_minimum_required(VERSION 3.22)

# project, which is done via external_rules.cmake, one directory above.

cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.22)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it would be helpful to add a comment explaining why this specific minimum version of CMake is required. This provides context for future developers. Since this file is for a sub-project, syncing with the main project's CMake version is a good reason.

Consider adding a comment like:

# Keep minimum CMake version in sync with the main project.
c_minimum_required(VERSION 3.22)

@AustinBenoit AustinBenoit added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant