Removing webframeworks questions from init hosting #9843
Conversation
Summary of ChangesHello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly simplifies the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully simplifies the hosting initialization flow by removing questions related to web frameworks, which aligns with the stated goal. The addition of unit tests for this streamlined process is a valuable improvement. My review includes a few suggestions to enhance the code's robustness and maintainability, both in the core logic and the new tests.
| sandbox.restore(); | ||
| }); | ||
|
|
||
| describe("askQuestions", () => { |
There was a problem hiding this comment.
The mock options object is created inline with as any in multiple tests. To improve readability, reduce repetition, and make it easier to manage, consider defining a constant for these mock options at the top of the describe block and reusing it in your tests.
| }); | ||
| }); | ||
|
|
||
| describe("actuate", () => { |
There was a problem hiding this comment.
The stub for Client.prototype.get is repeated across all tests within this describe block. To reduce code duplication and improve maintainability, consider moving this common setup into a beforeEach hook.
| await config.askWriteProjectFile( | ||
| `${hostingInfo.public}/index.html`, | ||
| INDEX_TEMPLATE.replace(/{{VERSION}}/g, response.body.current.version), | ||
| `${hostingInfo.public}/404.html`, |
There was a problem hiding this comment.
Using string interpolation to construct file paths can be brittle. For example, if hostingInfo.public is an empty string, the path becomes '/404.html', which might not be what you intend. Using path.join() is more robust for constructing paths as it correctly handles path segments.
You will need to add import { join } from 'path'; at the top of the file.
| `${hostingInfo.public}/404.html`, | |
| join(hostingInfo.public, "404.html"), |
| const c = new Client({ urlPrefix: "https://www.gstatic.com", auth: false }); | ||
| const response = await c.get<{ current: { version: string } }>("/firebasejs/releases.json"); | ||
| await config.askWriteProjectFile( | ||
| `${hostingInfo.public}/index.html`, |
There was a problem hiding this comment.
For robustness, use path.join to construct this file path instead of string interpolation.
| `${hostingInfo.public}/index.html`, | |
| join(hostingInfo.public, "index.html"), |
1 participant
Description
Removing the web frameworks set up flow from
firebase init hosting, and adding a unit test while we are here.