increase timeout for `npm run test` and factor in timezone day diff for `datetimeString` test #9812

aalej · 2026-01-26T20:58:32Z

Description

when running npm run test a bunch of tests fail. It seems to mostly be timing out. Increasing the timeout to ~~10s~~ 5s. Also, one test was failing because of timezone causing the day to be different by 1. The longest test ran ~2s, ~~so maybe we could set it to 5s intead?~~ set the timeout to 5s

 availableTools
    ✔ should return specific tools when enabledTools is provided
    ✔ should return core tools by default (1789ms)

failing tests with "npm run test"

3942 passing (54s)
  6 pending
  16 failing

  1) firestore:bulkdelete
       should throw an error if collection-ids is not provided:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-bulkdelete.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  2) firestore:bulkdelete
       should call bulkDeleteDocuments with the correct parameters:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-bulkdelete.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  3) firestore:bulkdelete
       should call bulkDeleteDocuments with the correct database:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-bulkdelete.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  4) firestore:bulkdelete
       should throw an error if the API call fails:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-bulkdelete.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  5) firestore:databases:create
       should create a new database with the correct parameters:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  6) firestore:databases:create
       should throw an error if location is not provided:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  7) firestore:databases:create
       should throw an error for invalid delete protection option:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  8) firestore:databases:create
       should throw an error for invalid point-in-time recovery option:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  9) firestore:databases:create
       should throw an error for invalid edition option:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  10) firestore:databases:create
       should create a database with delete protection enabled:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  11) firestore:databases:create
       should create a database with point-in-time recovery enabled:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  12) firestore:databases:create
       should create a database with a KMS key:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  13) firestore:databases:create
       should throw an error if the API call fails:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/commands/firestore-databases-create.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  14) availablePrompts
       should return core prompts by default:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/mcp/prompts/index.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  15) availablePrompts
       should not include feature prompts if not in activeFeatures:
     Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alejandromarco/Desktop/firebase-tools/git-clone/firebase-tools/src/mcp/prompts/index.spec.ts)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

  16) utils
       datetimeString
         should output the date in the correct format:
     AssertionError: expected '2020-02-23 02:35:45' to match /^2020-02-22 \d\d:35:45$/
      at Context.<anonymous> (src/utils.spec.ts:272:85)
      at processImmediate (node:internal/timers:485:21)

Scenarios Tested

npm run test

 3958 passing (54s)
  6 pending

Sample Commands

gemini-code-assist · 2026-01-26T20:58:43Z

Summary of Changes

Hello @aalej, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues encountered when running npm run test, specifically focusing on test failures due to insufficient timeouts and timezone discrepancies. By adjusting the global test timeout and refining a date utility test, the changes aim to ensure a more stable and reliable test suite execution.

Highlights

Test Timeout Increase: The Mocha test timeout has been increased from 1000ms to 10000ms (10 seconds) to prevent tests from timing out, especially those involving Firestore operations.
Timezone Handling in Tests: The datetimeString utility test has been updated to account for potential day shifts caused by timezone differences, making the test more robust across various environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request addresses failing tests by increasing the global test timeout and adjusting a date-related test to be more resilient to timezone variations. While the approach is sound, I have a couple of suggestions for improvement. The new timeout of 10 seconds seems a bit high given the test execution times mentioned, and a more conservative value might be better for catching performance regressions. Additionally, there's a minor syntax issue in the updated regular expressions for date validation that needs to be corrected.

gemini-code-assist · 2026-01-26T21:01:13Z

src/utils.spec.ts

      expect(utils.datetimeString(new Date("February 22, 2020 11:35:45-07:00"))).to.match(
-        /^2020-02-22 \d\d:35:45$/,
+        /^2020-02-2[2|3] \d\d:35:45$/,
      );
      expect(utils.datetimeString(new Date("February 7, 2020 11:35:45-07:00"))).to.match(
-        /^2020-02-07 \d\d:35:45$/,
+        /^2020-02-0[7|8] \d\d:35:45$/,
      );
      expect(utils.datetimeString(new Date("February 7, 2020 8:01:01-07:00"))).to.match(
-        /^2020-02-07 \d\d:01:01$/,
+        /^2020-02-0[7|8] \d\d:01:01$/,
      );


The regular expressions you've updated to handle timezone differences have a small syntax error. Inside a character class [], the pipe | is treated as a literal character, not an 'OR' operator.

For example, [2|3] matches the characters '2', '|', or '3', which is not the intended behavior of matching either '2' or '3'.

The correct way to specify an 'OR' condition for characters within a character class is to just list them, like [23].

I'll provide a suggestion to fix the regex patterns.

Suggested change

expect(utils.datetimeString(new Date("February 22, 2020 11:35:45-07:00"))).to.match(

/^2020-02-22 \d\d:35:45$/,

/^2020-02-2[2|3] \d\d:35:45$/,

);

expect(utils.datetimeString(new Date("February 7, 2020 11:35:45-07:00"))).to.match(

/^2020-02-07 \d\d:35:45$/,

/^2020-02-0[7|8] \d\d:35:45$/,

);

expect(utils.datetimeString(new Date("February 7, 2020 8:01:01-07:00"))).to.match(

/^2020-02-07 \d\d:01:01$/,

/^2020-02-0[7|8] \d\d:01:01$/,

);

expect(utils.datetimeString(new Date("February 22, 2020 11:35:45-07:00"))).to.match(

/^2020-02-2[23] \d\d:35:45$/,

);

expect(utils.datetimeString(new Date("February 7, 2020 11:35:45-07:00"))).to.match(

/^2020-02-0[78] \d\d:35:45$/,

);

expect(utils.datetimeString(new Date("February 7, 2020 8:01:01-07:00"))).to.match(

/^2020-02-0[78] \d\d:01:01$/,

);

good catch! I completely forgot that regex works like that

gemini-code-assist · 2026-01-26T21:01:14Z

.mocharc.yml

 file:
  - src/test/helpers/global-mock-auth.ts
-timeout: 1000
+timeout: 10000


While increasing the timeout is necessary to fix the failing tests, a 10-second timeout might be overly generous and could mask future performance regressions in the test suite. In the pull request description, you mentioned that the longest test runs in about 2 seconds and suggested that 5 seconds might be a better value. I agree with that assessment. A 5-second timeout should be sufficient to prevent timeouts due to normal fluctuations while still being tight enough to catch performance issues.

timeout: 5000

updating the timeout to 5s

aalej · 2026-01-26T21:07:27Z

/gemini review

gemini-code-assist

Code Review

This pull request addresses test failures by increasing the Mocha timeout and making a date formatting test robust to timezone differences. The timeout increase to 5 seconds seems reasonable given the context of tests timing out at 1 second. The fix for the datetimeString test correctly handles day changes across timezones for the existing test cases. I've added one suggestion to further improve the robustness of these date-related tests by considering edge cases like month and year boundaries.

gemini-code-assist · 2026-01-26T21:08:44Z

src/utils.spec.ts

      expect(utils.datetimeString(new Date("February 22, 2020 11:35:45-07:00"))).to.match(
-        /^2020-02-22 \d\d:35:45$/,
+        /^2020-02-2[23] \d\d:35:45$/,
      );
      expect(utils.datetimeString(new Date("February 7, 2020 11:35:45-07:00"))).to.match(
-        /^2020-02-07 \d\d:35:45$/,
+        /^2020-02-0[78] \d\d:35:45$/,
      );
      expect(utils.datetimeString(new Date("February 7, 2020 8:01:01-07:00"))).to.match(
-        /^2020-02-07 \d\d:01:01$/,
+        /^2020-02-0[78] \d\d:01:01$/,
      );


While this change correctly fixes the test for different timezones by allowing for a day difference, it might not cover all edge cases, such as month or year boundaries. For example, a date like December 31, 2020 20:00:00Z could be 2021-01-01 in some timezones, causing both the day, month, and year to change.

To make the tests more robust, you could consider:

Mocking the timezone for these tests (which might require an external library).

Adding test cases for boundary conditions (e.g., end of month, end of year) to ensure datetimeString behaves as expected across timezone-induced date changes.

For now, for this specific test, I think we can ignore this edge case? the purpose of the test is to check if dateTimeString util will correctly format a date object into a YYYY-mm-dd HH:mm:ss format

aalej added 2 commits January 27, 2026 04:29

increase timeout

007fcc3

modify regex to factor day diffence due to timezone

7164238

aalej changed the title ~~Aalej npmruntest fix~~ increase timeout for npm run test and factor in timezone day diff for datetimeString test Jan 26, 2026

gemini-code-assist bot reviewed Jan 26, 2026

View reviewed changes

aalej added 2 commits January 27, 2026 05:05

make timeout 5s

d0b7e87

correct regex mistake

39015b5

gemini-code-assist bot reviewed Jan 26, 2026

View reviewed changes

aalej requested a review from joehan January 27, 2026 07:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

increase timeout for `npm run test` and factor in timezone day diff for `datetimeString` test #9812

increase timeout for `npm run test` and factor in timezone day diff for `datetimeString` test #9812

aalej commented Jan 26, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 26, 2026

Uh oh!

aalej Jan 26, 2026

Uh oh!

gemini-code-assist bot Jan 26, 2026

Uh oh!

aalej Jan 26, 2026

Uh oh!

aalej commented Jan 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 26, 2026

Uh oh!

aalej Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

increase timeout for npm run test and factor in timezone day diff for datetimeString test #9812

Are you sure you want to change the base?

increase timeout for npm run test and factor in timezone day diff for datetimeString test #9812

Conversation

aalej commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Scenarios Tested

Sample Commands

Uh oh!

gemini-code-assist bot commented Jan 26, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

aalej Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

aalej Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

aalej commented Jan 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

aalej Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

increase timeout for `npm run test` and factor in timezone day diff for `datetimeString` test #9812

increase timeout for `npm run test` and factor in timezone day diff for `datetimeString` test #9812

aalej commented Jan 26, 2026 •

edited

Loading