refactor(firestore-bigquery-export): refactor fs-bq-schema-views to use CTE query builder#2581
Open
refactor(firestore-bigquery-export): refactor fs-bq-schema-views to use CTE query builder#2581
Conversation
cabljac
changed the title
HassanBahati
changed the title
CorieW
reviewed
Jan 9, 2026
| const firstValue = (selector: string, isArrayType?: boolean) => { | ||
| if (isArrayType) return selector; | ||
| return `FIRST_VALUE(${selector}) OVER(PARTITION BY document_name ORDER BY timestamp DESC)`; | ||
| // For CTE + JOIN pattern, we don't need window functions - just return the selector as-is |
| // Replace JSON_EXTRACT(data, with JSON_EXTRACT(t.data, | ||
| // But be careful not to replace if already "t.data" | ||
| let updatedExtractor = String(extractor); | ||
| if (!updatedExtractor.includes("t.data")) { |
Member
There was a problem hiding this comment.
Is this check required since you're technically replacing JSON_EXTRACT_SCALAR(data with JSON_EXTRACT_SCALAR(t.data etc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2557
Manual Testing