Allow user associated with process to stop it.#21
Open
AlexEshoo wants to merge 2 commits intofhd:masterfrom
Open
Allow user associated with process to stop it.#21AlexEshoo wants to merge 2 commits intofhd:masterfrom
AlexEshoo wants to merge 2 commits intofhd:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in #20 the process stored in
/var/run/pid_fileis the PID for the commandsudo -U <user> <cmd>which causes an error when the user attempts to stop the process sincekill <pid>is not allowed because the pid is owned by root.pgrep -U "$user" -xf "$cmd"captures the pid for the actual running script which is owned by$user, therefore allowing them to successfully stop the service without sudo.