add new stellar evolution derivative from SSPtools#5
Open
nmdickson wants to merge 2 commits intoffronimo:masterfrom
Open
add new stellar evolution derivative from SSPtools#5nmdickson wants to merge 2 commits intoffronimo:masterfrom
nmdickson wants to merge 2 commits intoffronimo:masterfrom
Conversation
Replaces (optionally, but by default) the old power law based stellar evolution logic with the new `LuminousEvMassLoss` class and derivatives from `ssptools`, re-using some of the quantities used in the `InitialBHPopulation` computation as well.
As it currently stands, starting with no BHs causes mbh=0/0=NaN at time 0 and thus causes the ODE solver to hang. This quick check just raises an error before that can happen. In principle this should be revisited and actually fixed in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces (optionally, but by default) the old power law based stellar evolution logic with the new
LuminousEvMassLossclass and derivatives fromssptools, re-using some of the quantities used in theInitialBHPopulationcomputation as well.This adds the
ssp_sevflag, which should be turned on alongsidesspandsevto use the new logic. Also adds a new derivative to the ODEs, tracking the number of stars over time. Though currently this only includes the stellar evolution N losses, and doesn't affect anything but the mean stellar mass.Requires
astro-ssptools>=2.1.0.