This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Remove rounding errors in create_mesh#68
Open
bguillard wants to merge 1 commit intofacebookresearch:mainfrom
Open
Remove rounding errors in create_mesh#68bguillard wants to merge 1 commit intofacebookresearch:mainfrom
bguillard wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current code for sampling a grid of SDF values, there is a rounding error in the computation of the regularly spaced 3D coordinates of the grid.
To exemplify my point, for
N=256(default), the (x,y,z)=(1,1,1) edge of the bounding box instead has coordinatesThis error does not only affect coordinates on the cube's boundaries, but the whole volume.
I propose to properly carry integer division, which now yields:
Despite the error in 3D coordinates being small, I have found this fix to improve 3D reconstruction metrics quite a bit (~5% on my task).