Add options for proof directive title formatting #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces new configuration options: proof_title_format, proof_number_weight, and proof_title_weight, allowing users to customize the format and font weight of proof directive titles. Documentation and CSS updated to reflect these changes, and directive logic now applies the user-defined title format.
for more information, see https://pre-commit.ci
douden
requested review from
mmcky
and removed request for
Tom-van-Woudenberg
Contributor
Author
|
@mmcky : I have no idea why the ci - tests fail. Do you have any idea? Maybe tests are outdated? |
Updated the CI workflow to install the sphinx-testing package before running tests. This ensures that all required testing dependencies are available during CI runs.
Eliminated the installation of sphinx-testing from the CI workflow and replaced its path import in tests/conftest.py with the standard os.path module.
Added missing newline at end of several test files and switched from os.path to pathlib in conftest.py for improved path handling. Also updated some test HTML content to fix encoding issues.
for more information, see https://pre-commit.ci
Replaces invalid or non-ASCII characters in test HTML files with correct ASCII equivalents to improve readability and consistency in test outputs.
Appends a newline at the end of several HTML and LaTeX test files to ensure consistency and avoid warnings from tools that expect files to end with a newline.
for more information, see https://pre-commit.ci
Contributor
Author
Tom-van-Woudenberg
requested changes
Jan 21, 2026
Expanded documentation on customizing proof directive title formats and font weights, providing clearer explanations and examples. Removed unnecessary !important from CSS font-weight rules for proof titles and numbers.
for more information, see https://pre-commit.ci
Updated the CSS selectors in the asset copying logic to match rules without the !important flag by default. This allows custom font-weight values to be injected with !important only when configured, improving CSS override flexibility.
…hinx-proof into title-styling
The '!important' flag was removed from the dynamically generated CSS for proof number and title font weights. This change allows for easier CSS overrides and better integration with existing styles.
Tom-van-Woudenberg
approved these changes
Jan 22, 2026
|
Probably nice to add tests ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new configuration options: proof_title_format, proof_number_weight, and proof_title_weight, allowing users to customize the format and font weight of proof directive titles. Documentation and CSS updated to reflect these changes, and directive logic now applies the user-defined title format.