Skip to content

build: fix docker-compose for evm #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 1 commit into from
Jan 28, 2026
Merged

build: fix docker-compose for evm #3022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions apps/evm/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,31 @@ get_home_dir() {
# Get the home directory (either from --home flag or default)
CONFIG_HOME=$(get_home_dir "$@")

# Create config directory
mkdir -p "$CONFIG_HOME"

# Create passphrase file if environment variable is set
PASSPHRASE_FILE="$CONFIG_HOME/passphrase.txt"
if [ -n "$EVM_SIGNER_PASSPHRASE" ]; then
echo "$EVM_SIGNER_PASSPHRASE" > "$PASSPHRASE_FILE"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using echo can add an unwanted trailing newline to the passphrase file. While the Go application appears to handle this by trimming whitespace, it's safer and more precise to use printf '%s' to ensure the secret is written to the file exactly as it is in the environment variable, without any modifications.

Suggested change
echo "$EVM_SIGNER_PASSPHRASE" > "$PASSPHRASE_FILE"
printf '%s' "$EVM_SIGNER_PASSPHRASE" > "$PASSPHRASE_FILE"

chmod 600 "$PASSPHRASE_FILE"
fi

# Create JWT secret file if environment variable is set
JWT_SECRET_FILE="$CONFIG_HOME/jwt.hex"
if [ -n "$EVM_JWT_SECRET" ]; then
echo "$EVM_JWT_SECRET" > "$JWT_SECRET_FILE"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using echo can add an unwanted trailing newline to the JWT secret file. It's safer and more precise to use printf '%s' to ensure the secret is written to the file exactly as it is in the environment variable, without any modifications.

Suggested change
echo "$EVM_JWT_SECRET" > "$JWT_SECRET_FILE"
printf '%s' "$EVM_JWT_SECRET" > "$JWT_SECRET_FILE"

chmod 600 "$JWT_SECRET_FILE"
fi

if [ ! -f "$CONFIG_HOME/config/node_key.json" ]; then

# Build init flags array
init_flags="--home=$CONFIG_HOME"

# Add required flags if environment variables are set
if [ -n "$EVM_SIGNER_PASSPHRASE" ]; then
init_flags="$init_flags --rollkit.node.aggregator=true --rollkit.signer.passphrase $EVM_SIGNER_PASSPHRASE"
init_flags="$init_flags --evnode.node.aggregator=true --evnode.signer.passphrase_file $PASSPHRASE_FILE"
fi

INIT_COMMAND="evm init $init_flags"
Expand All @@ -52,7 +69,7 @@ default_flags="--home=$CONFIG_HOME"

# Add required flags if environment variables are set
if [ -n "$EVM_JWT_SECRET" ]; then
default_flags="$default_flags --evm.jwt-secret $EVM_JWT_SECRET"
default_flags="$default_flags --evm.jwt-secret-file $JWT_SECRET_FILE"
fi

if [ -n "$EVM_GENESIS_HASH" ]; then
Expand All @@ -68,28 +85,28 @@ if [ -n "$EVM_ETH_URL" ]; then
fi

if [ -n "$EVM_BLOCK_TIME" ]; then
default_flags="$default_flags --rollkit.node.block_time $EVM_BLOCK_TIME"
default_flags="$default_flags --evnode.node.block_time $EVM_BLOCK_TIME"
fi

if [ -n "$EVM_SIGNER_PASSPHRASE" ]; then
default_flags="$default_flags --rollkit.node.aggregator=true --rollkit.signer.passphrase $EVM_SIGNER_PASSPHRASE"
default_flags="$default_flags --evnode.node.aggregator=true --evnode.signer.passphrase_file $PASSPHRASE_FILE"
fi

# Conditionally add DA-related flags
if [ -n "$DA_ADDRESS" ]; then
default_flags="$default_flags --rollkit.da.address $DA_ADDRESS"
default_flags="$default_flags --evnode.da.address $DA_ADDRESS"
fi

if [ -n "$DA_AUTH_TOKEN" ]; then
default_flags="$default_flags --rollkit.da.auth_token $DA_AUTH_TOKEN"
default_flags="$default_flags --evnode.da.auth_token $DA_AUTH_TOKEN"
fi

if [ -n "$DA_NAMESPACE" ]; then
default_flags="$default_flags --rollkit.da.namespace $DA_NAMESPACE"
default_flags="$default_flags --evnode.da.namespace $DA_NAMESPACE"
fi

if [ -n "$DA_SIGNING_ADDRESSES" ]; then
default_flags="$default_flags --rollkit.da.signing_addresses $DA_SIGNING_ADDRESSES"
default_flags="$default_flags --evnode.da.signing_addresses $DA_SIGNING_ADDRESSES"
fi

# If no arguments passed, show help
Expand Down
Loading