refactor: bump ev-node and ev-node/core to rcs #331
Conversation
Summary of ChangesHello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependencies in go.mod and go.sum, including ev-node and cometbft, and removes an unnecessary keytransform wrapper. The InitChain and ExecuteTxs methods in pkg/adapter/adapter.go are modified to align with the updated execution.Executor interface, removing uint64 from their return signatures. The review comments highlight the need to ensure that all call sites are updated to reflect these signature changes.
| if a.AppGenesis.GenesisTime != genesisTime { | ||
| err := fmt.Errorf("genesis time mismatch: expected %s, got %s", a.AppGenesis.GenesisTime, genesisTime) | ||
| return nil, 0, err | ||
| return nil, err |
There was a problem hiding this comment.
The return signature for InitChain has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
| if a.AppGenesis.ChainID != chainID { | ||
| err := fmt.Errorf("chain ID mismatch: expected %s, got %s", a.AppGenesis.ChainID, chainID) | ||
| return nil, 0, err | ||
| return nil, err |
There was a problem hiding this comment.
The return signature for InitChain has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
| if initialHeight != uint64(a.AppGenesis.InitialHeight) { | ||
| err := fmt.Errorf("initial height mismatch: expected %d, got %d", a.AppGenesis.InitialHeight, initialHeight) | ||
| return nil, 0, err | ||
| return nil, err |
There was a problem hiding this comment.
The return signature for InitChain has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
| }) | ||
| if err != nil { | ||
| return nil, 0, fmt.Errorf("app initialize chain: %w", err) | ||
| return nil, fmt.Errorf("app initialize chain: %w", err) |
There was a problem hiding this comment.
The return signature for InitChain has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
| vals, err := cmttypes.PB2TM.ValidatorUpdates(res.Validators) | ||
| if err != nil { | ||
| return nil, 0, fmt.Errorf("validator updates: %w", err) | ||
| return nil, fmt.Errorf("validator updates: %w", err) |
There was a problem hiding this comment.
The return signature for InitChain has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
| }() | ||
| if err != nil { | ||
| return nil, 0, err | ||
| return nil, err |
There was a problem hiding this comment.
The return signature for ExecuteTxs has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
|
|
||
| if err := a.Store.SaveBlockID(ctx, blockHeight, currentBlockID); err != nil { | ||
| return nil, 0, fmt.Errorf("save block ID: %w", err) | ||
| return nil, fmt.Errorf("save block ID: %w", err) |
There was a problem hiding this comment.
The return signature for ExecuteTxs has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
| // save response before the events are fired (current behaviour in CometBFT) | ||
| if err := a.Store.SaveBlockResponse(ctx, blockHeight, fbResp); err != nil { | ||
| return nil, 0, fmt.Errorf("save block response: %w", err) | ||
| return nil, fmt.Errorf("save block response: %w", err) |
There was a problem hiding this comment.
The return signature for ExecuteTxs has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
|
|
||
| if err := fireEvents(a.EventBus, abciBlock, currentBlockID, fbResp, validatorUpdates); err != nil { | ||
| return nil, 0, fmt.Errorf("fire events: %w", err) | ||
| return nil, fmt.Errorf("fire events: %w", err) |
There was a problem hiding this comment.
The return signature for ExecuteTxs has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
| a.Logger.Info("block executed successfully", "height", blockHeight, "appHash", fmt.Sprintf("%X", fbResp.AppHash)) | ||
|
|
||
| return fbResp.AppHash, uint64(s.ConsensusParams.Block.MaxBytes), nil | ||
| return fbResp.AppHash, nil |
There was a problem hiding this comment.
The return signature for ExecuteTxs has changed, removing uint64 from the return values. Ensure that all call sites are updated to reflect this change.
Overview