Open
Conversation
janjakubnanista
force-pushed
the
jan/op-deployer-update
branch
from
009045a to
815c4fb
Compare
sigma
reviewed
Jan 27, 2025
test/e2e/lib/bats
Outdated
Collaborator
There was a problem hiding this comment.
could we potentially install bats (and support/assert libs) through mise?
Collaborator
Author
There was a problem hiding this comment.
Unfortunately not, they do not package them as binaries, especially the assert & support don't expose a binary - they just need to be sourced into the test file.
Collaborator
Author
There was a problem hiding this comment.
Actually I found bats itself in the package registries so I dropped that submodule, the support & assert remain
janjakubnanista
force-pushed
the
jan/op-deployer-update
branch
from
fd93ffe to
ef98af2
Compare
janjakubnanista
force-pushed
the
jan/op-deployer-update
branch
from
fb85670 to
9e54fe2
Compare
sigma
requested changes
Jan 28, 2025
| local OP_GETH_ISTHMUS_TIME=$(jq '.result.protocols.eth.config.isthmusTime' <<< $OP_GETH_NODE_INFO_JSON) | ||
| assert_equal "$OP_GETH_ISTHMUS_TIME" "0" | ||
|
|
||
| kurtosis enclave rm -f $ENCLAVE_ID |
Collaborator
There was a problem hiding this comment.
I'm worried we might be leaking enclaves if the tests fail.
Should we have "kurtosis enclave add/rm" in setup/teardown functions around the test itself (or at the suite level to save time/resources)?
samlaf
reviewed
Feb 13, 2025
Co-authored-by: Samuel Laferriere <samlaf92@gmail.com> Signed-off-by: Ján Jakub Naništa <jan.jakub.nanista@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
The ultimate goal of this PR is proposal of E2E testing strategy for the
optimism-packagebased onBATS. It is not intended to be merged in one go - it combines several steps needed to get to the point where CI E2E pipeline is running:mise.tomlfor developer tooling setupJustfilebuilding and testingBATSgit submodules (the standard way of addingBATS)