fix: add missing storage bases for erc7779

[livingrockrises]

added PREVALIDATION_HOOKMANAGER_STORAGE_LOCATION

commented for questions in PR file diff view

[livingrockrises]

should we uninstall pre validation hooks as well?

why try... used instead of regular uninstall methods?

[highskore]

Regular uninstall could revert right?

[livingrockrises]

I noticed we're not posting any data for onUninstall
commented versions of some methods like _tryUninstallValidators had that

[highskore]

hmm actually that's a good point. Let keep and use the versions that post data with tryUninstall

[livingrockrises]

would this need changes in the erc for onRedelegation method--can accept data?

interface IRedelegableDelegatedAccount {
	/*
	 * @dev    Function called before redelegation.
	 *         This function should prepare the account for a delegation to a different implementation.
	 *         This function could be triggered by the new wallet that wants to redelegate an already delegated EOA.
	 *         It should uninitialize storages if needed and execute wallet-specific logic to prepare for redelegation.
	 *         msg.sender should be the owner of the account.
	 */
	function onRedelegation() external returns (bool);
}

[livingrockrises]

@highskore @kopy-kat

[highskore]

yeah that makes sense

[livingrockrises]

pushed please check.

[highskore]

looks good now, lets just make sure the linter is passing

[livingrockrises]

@highskore
There's an audit comment on Fallback handlers persisting after redelegation.
so I plan to push a commit which maintains an array of fallback selectors besides the current mapping and update install, uninstall method and add a new one _tryUninstallFallbackHandlers()

[highskore]

@highskore

There's an audit comment on Fallback handlers persisting after redelegation.

so I plan to push a commit which maintains an array of fallback selectors besides the current mapping and update install, uninstall method and add a new one _tryUninstallFallbackHandlers()

nice sounds good

[livingrockrises]

@highskore
There's an audit comment on Fallback handlers persisting after redelegation.
so I plan to push a commit which maintains an array of fallback selectors besides the current mapping and update install, uninstall method and add a new one _tryUninstallFallbackHandlers()

nice sounds good

pushed.

[livingrockrises]

please give me until next week to finalise this PR. I spoke to David and we agreed on not changing the onRedelegation interface now

[Rahul-cyber26]

[Rahul-cyber26]

        _addStorageBase(PREVALIDATION_HOOKMANAGER_STORAGE_LOCATION);

[Rahul-cyber26]

evm_version = "prague"