Closed
Conversation
wagenet
force-pushed
the
typings-export
branch
2 times, most recently
from
56dc9a7 to
49d5ad0
Compare
chriskrycho
suggested changes
Mar 28, 2022
Contributor
chriskrycho
left a comment
chriskrycho
left a comment
There was a problem hiding this comment.
Couple of nits from the modules affected, will deeply-read-and-understand build-docs.js next.
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
Outdated
Show resolved
Hide resolved
wagenet
force-pushed
the
typings-export
branch
3 times, most recently
from
46de6a4 to
cc3f254
Compare
wagenet
force-pushed
the
typings-export
branch
from
94df899 to
8d62688
Compare
Contributor
|
I see a lot of conflicts. Has the work been done elsewhere? |
Member
|
Is this still relevant? It is a draft PR |
Contributor
|
I believe this was superceded in its entirety by #20449 (as well as the foundational PRs which preceded it); this was Peter's admirable first pass at trying to get types publishing, and was invaluable prior art in informing the Ember TypeScript team that we were going to have to do the absolute shenanigans that we did in #20449 to get things published. Closing accordingly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #20090