chore: replace json-stable-stringify with safe-stable-stringify#738
Open
BridgeAR wants to merge 2 commits intoember-cli:masterfrom
Open
chore: replace json-stable-stringify with safe-stable-stringify#738BridgeAR wants to merge 2 commits intoember-cli:masterfrom
BridgeAR wants to merge 2 commits intoember-cli:masterfrom
Conversation
This is a performance improvement as the latter is actually faster. json-stable-stringify x 13,870 ops/sec ±0.72% (94 runs sampled) safe-stable-stringify x 30,367 ops/sec ±0.39% (96 runs sampled) The only difference is that objects with circular reference are from now on also accepted instead of throwing an error.
Member
|
Hmm, not sure why CI didn't run. Merging master here again to see if that kicks things off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a performance improvement as the latter is actually faster.
json-stable-stringify x 13,870 ops/sec ±0.72% (94 runs sampled)
safe-stable-stringify x 30,367 ops/sec ±0.39% (96 runs sampled)
The only difference is that objects with circular reference are from
now on also accepted instead of throwing an error.