Add round pixels and orange theme#60
Open
marcpabst wants to merge 1 commit intoembedded-graphics:masterfrom
Open
Add round pixels and orange theme#60marcpabst wants to merge 1 commit intoembedded-graphics:masterfrom
marcpabst wants to merge 1 commit intoembedded-graphics:masterfrom
Conversation
rename colour theme
Member
It's a bit outside the original scope of the simulator, but it probably looks nice. And because it's a minor non breaking change I wouldn't mind merging it. |
rfuest
reviewed
Jan 22, 2025
|
|
||
| self.data[start_index..start_index + output_color.len()] | ||
| .copy_from_slice(output_color) | ||
| match self.output_settings.pixel_shape { |
Member
There was a problem hiding this comment.
This match should be moved outside the points loop to remove it from the hot path.
| scale: Option<u32>, | ||
| pixel_spacing: Option<u32>, | ||
| theme: BinaryColorTheme, | ||
| pixel_shape: Option<PixelShape>, |
Member
There was a problem hiding this comment.
There is no need to use an option for the pixel shape, because Square is the default:
Suggested change
| pixel_shape: Option<PixelShape>, | |
| pixel_shape: PixelShape, |
Contributor
|
Crashes when pixel shape set to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how useful this is, but I think it's quite nice for people using led matrices. It's minor changes, so I'm just leaving this here - if there's interest to merge, I'll go through the PR checklist.
Thank you for helping out with embedded-graphics-simulator development! Please:
CHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public APIrustfmton the projectjust build(Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.PR description
[add your PR description here]