refactor: don't merge asars that are identical in the x64 and arm64 versions#68
Open
aprilandjan wants to merge 3 commits intoelectron:mainfrom
Open
refactor: don't merge asars that are identical in the x64 and arm64 versions#68aprilandjan wants to merge 3 commits intoelectron:mainfrom
aprilandjan wants to merge 3 commits intoelectron:mainfrom
Conversation
…ons even if options.mergeASARs is set to true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
mergeASARsworkflow will always be done even if the two asar files are identical, which seems to be unnecessary and not fit for the annotation right before the code block:This PR simply move
mergeASARsworkflow into the branch of different asar files. Otherwise, use one of them directly.Please have a look :)