fix: refactor index.ts to separate files for files & integrity operations#121
Draft
mmaietta wants to merge 1 commit intoelectron:mainfrom
Draft
fix: refactor index.ts to separate files for files & integrity operations#121mmaietta wants to merge 1 commit intoelectron:mainfrom
mmaietta wants to merge 1 commit intoelectron:mainfrom
Conversation
…utils, asar utils, integrity generator)
mmaietta
changed the title
Contributor
Author
Contributor
Author
|
Quick note: I'll pick this back up after I finish squashing some bugs in other projects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
index.tsinto dedicated files (file utils & integrity generator)asar.listPackagewas missing a 2nd argument. I checked withelectron/asarand its default behavior isisPack: false(https://github.com/electron/asar/blob/c2a5f3a59ba8e72365e9dc9a3cf3ad606f21734b/src/filesystem.ts#L188)copyAndShimAsarIfNeededcopySnapshotslipoMachOFilesmergeAppFilesinjectAsarIntegrityThis is to streamline fixing some bugs and make the PRs easier to read and understand: #116 #117
Plus, I'd like to contribute to the test suite, which will be easier to do with this refactor.