Conversation
|
@AerysL This makes sense to me. We did not pay much attention on the use of keyword "const". It seems like C++ is more strict on this than C. E.g., C allows mismatch between "const type *" and "type *" used in function prototypes and functions, but C++ does not. Please try to build with C++. Do "./configure --with-cxxcompiler" and "make -j test", and check if there is something missed. Nice work. Thanks! |
|
Good catch, the errors specifically are due to the fact that the reference BLAS implementation (and apparently some other BLAS implementations as well) don't declare const correctness correctly. I used the definitions used by MKL's implementation (which appears to be the same as the OpenBLAS implemenation). |
This improves the const correctness of EVSL. Useful for reasons such as
as per https://stackoverflow.com/questions/136880/sell-me-on-const-correctness