Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #387 by updating the egglog dependency from the "fix-fn-bug" branch to the "dag-extract" branch, which includes a fix for extraction with DAG-based cost models.
Key Changes:
- Updated all egglog-related dependencies to use the "dag-extract" branch instead of "fix-fn-bug"
- Added a comprehensive test case that verifies the extraction bug fix with a custom DAG-based cost model
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
python/tests/test_extract_bug.py |
New test file implementing a DAG-based cost model and testing extraction behavior to verify the bug fix |
Cargo.toml |
Updated 10 egglog dependency references from "fix-fn-bug" to "dag-extract" branch |
Cargo.lock |
Updated dependency lock file with new commit hashes corresponding to the "dag-extract" branch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #388 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #387 by updating egglog version. Also tested this on numba/sealir#15 usage of the dag cost extractor and it seems to work